fix: Don't return inputBuf if input is of type PDF #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #377 +/- ##
=======================================
Coverage 45.34% 45.34%
=======================================
Files 100 100
Lines 3670 3670
=======================================
Hits 1664 1664
Misses 1959 1959
Partials 47 47
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
pajlada
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
CHANGELOG.mdwas updated, if applicableDescription
Related to #374.
I have a maxThumbnailSize that is very high, which means that libvips default sizing for PDFs is within the limit, which is allowing this
ifcheck to return early:api/pkg/thumbnail/thumbnail.go
Lines 53 to 57 in 67a1371
That early return of the inputBuf makes this happen:
Which definitely isn't intentional.
This PR adds an additional conditional to the
ifcheck and moves some things around to make theformatvariable work without crashing if image errors out. (Calling image.Format() when previousimage, err := ...fails crashes the software, I learned.)Images
Before:
After:
And yes, I have thumbnails set to size 900 in Chatterino.